Add tableId to getItemEntry #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So if I understand these changes correctly, with the new tableId, the normal GET_ITEM macro uses the modIndex, but the new macro allows setting both separately? Otherwise the functionality is all the same? |
garrettjoecox
force-pushed
the
addTableIdToGetItemEntry
branch
from
ce7ebf8
to
fde5c3d
Compare
garrettjoecox
force-pushed
the
addTableIdToGetItemEntry
branch
from
fde5c3d
to
c9ad725
Compare
briaguya-ai
reviewed
Sep 5, 2023
garrettjoecox
force-pushed
the
addTableIdToGetItemEntry
branch
from
c9ad725
to
1273abd
Compare
|
So I guess whether we merge this would depend on whether we wanted to maintain the rando item table or not going forward. |
The rando item table is staying (at least I think?), it's the weird "in between" table that is the issue, it's stored in the randomzier table but has a vanilla mod ID |
garrettjoecox
force-pushed
the
addTableIdToGetItemEntry
branch
2 times, most recently
from
e134c12
to
24be50e
Compare
briaguya-ai
approved these changes
Dec 2, 2023
garrettjoecox
force-pushed
the
addTableIdToGetItemEntry
branch
from
24be50e
to
2b88620
Compare
garrettjoecox
force-pushed
the
addTableIdToGetItemEntry
branch
from
2b88620
to
87165b1
Compare
jamieklassen
pushed a commit
to jamieklassen/Shipwright
that referenced
this pull request
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't love it, but these comments explain why:
My use case is I need to serialize a getItemEntry and send it across the wire, and sending over the getItemID + modIndex does not suffice because the modIndex is not 1:1 with the table the entry is stored in.
Build Artifacts