Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create GAME_CONTROLLER_DB.md #3219

Merged
merged 1 commit into from Oct 9, 2023
Merged

Create GAME_CONTROLLER_DB.md #3219

merged 1 commit into from Oct 9, 2023

Conversation

briaguya-ai
Copy link
Contributor

@briaguya-ai briaguya-ai commented Sep 20, 2023 •
edited by github-actions bot

image

it'll be a lot nicer to review that way than looking at the md source

Build Artifacts

Archez
Archez approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Is there an easy way of knowing the exact commit hash for a release, or is it basically just a comparing their branch commit around the time we release. Wondering if we can automate new entries into this doc.

@garrettjoecox
Copy link
Contributor

Nice addition! Is there an easy way of knowing the exact commit hash for a release, or is it basically just a comparing their branch commit around the time we release. Wondering if we can automate new entries into this doc.

@briaguya-ai

@briaguya-ai
Copy link
Contributor Author

I manually checked based on release date, comparing what we shipped with what was in the repo at that time

For new releases it will just be whatever the latest commit was at build time

@garrettjoecox garrettjoecox merged commit 7e0cb66 into HarbourMasters:develop Oct 9, 2023
8 checks passed
@briaguya-ai briaguya-ai deleted the briaguya-ai-patch-1 branch March 3, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

@Archez Archez Archez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@briaguya-ai @garrettjoecox @Archez