Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ZAPDTR and OTRExporter to sub modules #3298

Merged
merged 12 commits into from Oct 17, 2023
Merged

Move ZAPDTR and OTRExporter to sub modules #3298

merged 12 commits into from Oct 17, 2023

Conversation

louist103
Copy link
Contributor

@louist103 louist103 commented Oct 17, 2023 •
edited by github-actions bot

@louist103
fix gitrepo
b0a0246
@louist103
commit
e256493
@louist103
Remove repo
a05b4b9
@louist103
git subrepo init ZAPDTR
9a3a881 
subrepo:
  subdir:   "ZAPDTR"
  merged:   "a05b4b9e"
upstream:
  origin:   "none"
  branch:   "master"
  commit:   "none"
git-subrepo:
  version:  "0.4.6"
  origin:   "???"
  commit:   "???"
@louist103
subrepo file
91e6a42
@louist103
git subrepo push ZAPDTR
94ccd52 
subrepo:
  subdir:   "ZAPDTR"
  merged:   "e6b07647"
upstream:
  origin:   "https://github.com/harbourmasters/ZAPDTR"
  branch:   "TEST_101623"
  commit:   "e6b07647"
git-subrepo:
  version:  "0.4.6"
  origin:   "???"
  commit:   "???"
@louist103
OTRExportre
b71a250
@louist103
git subrepo init .\OTRExporter\
4d6417a 
subrepo:
  subdir:   ".\OTRExporter\"
  merged:   "b71a2506"
upstream:
  origin:   "none"
  branch:   "master"
  commit:   "none"
git-subrepo:
  version:  "0.4.6"
  origin:   "???"
  commit:   "???"
@louist103
new subrepo (OTRExporter)
6c6c588
@louist103
git subrepo push OTRExporter
15f2913 
subrepo:
  subdir:   "OTRExporter"
  merged:   "89de1472"
upstream:
  origin:   "https://github.com/harbourmasters/OTRExporter"
  branch:   "TEST-101623"
  commit:   "89de1472"
git-subrepo:
  version:  "0.4.6"
  origin:   "???"
  commit:   "???"
@louist103
remove subrepos
3ff12db
@louist103
actually add the modules
4703f62
briaguya-ai
briaguya-ai approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@briaguya-ai briaguya-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally on linux, builds and runs fine with submodule init/update

garrettjoecox
garrettjoecox approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@garrettjoecox garrettjoecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building for me on mac as well

@louist103
Copy link
Contributor Author

Working on Windows.

@louist103 louist103 merged commit 4a70fea into HarbourMasters:develop Oct 17, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrettjoecox garrettjoecox garrettjoecox approved these changes

@briaguya-ai briaguya-ai briaguya-ai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louist103 @garrettjoecox @briaguya-ai