Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hook unregistration #3538

Merged

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Dec 18, 2023

This is from my upcoming rando changes branch but wanted to get it in separately to get some feedback.

  • Adds the ability to unregister hooks using the ID now returned from the registration
  • As a demo, updates Hyper Enemies and Hyper Bosses to only have their hooks registered when applicable

Ignore whitespace is recommended for the diff

Build Artifacts

Copy link
Contributor

@Pepe20129 Pepe20129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from these, LGTM!

soh/soh/Enhancements/mods.cpp Show resolved Hide resolved
soh/soh/Enhancements/mods.cpp Show resolved Hide resolved
soh/soh/Enhancements/mods.cpp Show resolved Hide resolved
@garrettjoecox
Copy link
Contributor Author

This is updated with the changes after findings from 2ship and develop-rando-changes branch

@garrettjoecox garrettjoecox merged commit a84227c into HarbourMasters:develop Feb 16, 2024
8 checks passed
@garrettjoecox garrettjoecox deleted the hook-unregistration branch February 16, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants