Cosmetics Editor entry for Ivan the Fairy

[skyyoshi86]

Added Cosmetics Editor entry to change the color of Ivan the Fairy

Build Artifacts

• soh.otr.zip
• soh-linux-compatibility.zip
• soh-linux-performance.zip
• soh-mac.zip
• soh-switch.zip
• soh-wiiu.zip
• soh-windows.zip

[jbodner09]

The changes to the CMakeSettings and MODDING.md seem unrelated to Ivan and shouldn't be included in this PR.

[skyyoshi86]

The changes to the CMakeSettings and MODDING.md seem unrelated to Ivan and shouldn't be included in this PR.

TY for Review! I'm learning. CMakeSettings.json file was generated/changed automatically, and now I don't know if I need to delete it. I now deleted it. Was it correct to delete it?

[jbodner09]

Yeah, it was most likely auto-generated by your IDE, but shouldn't have been. If other people run into this, it would be easy enough to add it to the git ignore list, but at least on my machine, the file doesn't exist, so I'm curious what your setup is.

[skyyoshi86]

Yeah, it was most likely auto-generated by your IDE, but shouldn't have been. If other people run into this, it would be easy enough to add it to the git ignore list, but at least on my machine, the file doesn't exist, so I'm curious what your setup is.

TY! I'm on Windows 10 using Visual Studio 2022. As I kept getting an "could not clone vcpkg" when trying to compile, I was told to use "& 'C:\Program Files\CMake\bin\cmake' -S . -B "build/x64" -G "Visual Studio 17 2022" -T v142 -A x64 -DVCPKG_ROOT="build/x64/vcpkg" -DBUILD_REMOTE_CONTROL=1" command when compiling. I was told that "It's trying to update the vcpkg that came installed with Visual Studio, rather than making a separate vcpkg clone just in the project."

[skyyoshi86]

Am I missing a step for this PR?

[briaguya-ai]

anyone know what this change is? it doesn't appear to be newline/not

[jbodner09]

Well it is, but github apparently displays it differently for markdown files than it does for code files. I checked out this branch and opened the file up in a hex editor just to confirm:

[jbodner09]

Since the other markdown files end in newlines, it should be fine to leave it.

[Archez]

Since the body and particle colors are the same (both default green or the cosmetic color), instead of doing this lookup twice in each draw func, you can instead do it once in the EnPartner_Update func, and have it set this->innerColor and this->outerColor to the right color, then the two draw funcs can be reverted to use those values again.

[skyyoshi86]

Since the body and particle colors are the same (both default green or the cosmetic color), instead of doing this lookup twice in each draw func, you can instead do it once in the EnPartner_Update func, and have it set this->innerColor and this->outerColor to the right color, then the two draw funcs can be reverted to use those values again.

TY for your help and feedback :D

1. How can I get the colors from Cosmetics Editor with a function similar to CVarGetColor24() that returns a Color_RGBAf value instead of returning a Color_RGB8 value?

-or-

2. Should I instead modify the declarations of this->innerColor and this->outerColor to be of type Color_RGB8 so I can assign the Cosmetic Editor colors via the CVarGetColor24() function?

EDIT:

3. Should I keep using my newly created variables ivanColor1 and ivanColor2 of type Color_RGB8 as an alternative to assign the colors if they have been changed in the Cosmetics Editor?

Thank you in advance :)

[Archez]

You can assign the individual color properties one by one, which will handle the casting from int to float.

Color_RGB8 idlePrim = CVarGetColor24(...);
this->innerColor.r = idlePrim.r;
this->innerColor.g = idlePrim.g;
...

Or if you are daring, you can change the Color_RGBAf in the EnPartner struct to be Color_RGBA8. Either way is fine.

[Archez]

Awesome, looks good now! 🙂