Add Modifier buttons to input viewer and support individual button outline modes #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspectredc
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
LGTM, I'll need to double check how the UI looks later but everything seems sensible to me. Just a small thing and then I was also curious about the Indent stuff, is using set values like that alright for different resolutions? (I know it's a small number anyway + I'm not a UI person)
Looking into other uses in the codebase it seems they don't specify a value for Indent calls, so I'll follow that same paradigm here. |
briaguya-ai
approved these changes
Apr 20, 2024
garrettjoecox
approved these changes
Apr 20, 2024
|
@Tawling if you have a chance could you sort the conflicts here? Mostly changing LUS -> Ship and cvar macro stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The input viewer did not have layers for representing the two modifier buttons. This PR adds
Mod1.png,Mod1Outline.png,Mod2.png, andMod2Outline.pngas new layers supported by the input viewer. (hidden by default)Additionally, this PR adds support for setting the Outline Mode for each button individually, or just using the same setting for all of them.
New modifier buttons:
Single setting for all buttons:
Separate setting per button:
Build Artifacts