Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the MonitorConfig on the fly #42

Open
ghost opened this issue Feb 17, 2018 · 3 comments
Open

Change the MonitorConfig on the fly #42

ghost opened this issue Feb 17, 2018 · 3 comments
Milestone

Comments

@ghost
Copy link

ghost commented Feb 17, 2018

Being able to change the MonitorConfig (or atleast the ExchangeList) on the fly would allow me to only consider trades from exchanges where I have money right now, which changes after pretty much every trade.

@HardlyDifficult HardlyDifficult added this to the PublicAPI milestone Feb 17, 2018
@HardlyDifficult
Copy link
Owner

You could consider this today by reviewing allTradingPairs on a coin instead of using the Best method.

The Best method allows specifying a specific exchange. Maybe we could change that to allow a whitelist (or blacklist?) to consider. I think this approach may be more scalable than changing MonitorConfig so for example you could consider orders which involve a Buy from Cryptopia and a Sell on any of the other 5 exchanges you have accounts on.

@HardlyDifficult
Copy link
Owner

Added an exchange whitelist to the Best call yesterday.

It would still be cool to add the ability to hot swap exchanges... so leaving this open.

@HardlyDifficult
Copy link
Owner

  • Stop updating exchange.
  • Remove trading pairs.
  • Remove the exchange.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant