Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localise background images #2

Closed
HarishTeens opened this issue Oct 20, 2019 · 13 comments
Closed

Localise background images #2

HarishTeens opened this issue Oct 20, 2019 · 13 comments
Labels

Comments

@HarishTeens
Copy link
Owner

The homepage has a slideshow animation , the URLs are referenced to web download the images locally and link them

@shivambachhety
Copy link

Kindly explain the contribution that needs to be done.

@HarishTeens
Copy link
Owner Author

background-image: url(http://i.imgur.com/K3mPv14.jpg)

This is line in .css which is responsible for loading the background slideshow in the landing page.
instead of fetching the image from the i.imgur.com , it should be fetching the images stored locally in the folder

@ikayz
Copy link

ikayz commented Oct 20, 2019

@HarishTeens can I take this on?

@HarishTeens
Copy link
Owner Author

@shivambachhety had requested before , if he doesnt sure you can go on @ikayz

@ikayz
Copy link

ikayz commented Oct 20, 2019

@HarishTeens sure thing

@HarishTeens
Copy link
Owner Author

work on this issue if you want to , I just created this for you issue

@shivambachhety
Copy link

@HarishTeens thanks, I am working on the issue. What path to give to local images folder?

@HarishTeens
Copy link
Owner Author

@shivambachhety Inside public create a folder /images and add those here

@shivambachhety
Copy link

Done, Kindly review shivambachhety@1b0c46a

@Askat08
Copy link

Askat08 commented Oct 21, 2019

Hi @HarishTeens. Is there anything similar to this issue, where i can practice my skills?

@ikayz
Copy link

ikayz commented Oct 21, 2019

@HarishTeens thanks on it

@himanshunikhare-zz
Copy link

Can I work on this issue?

@HarishTeens
Copy link
Owner Author

Sorry guys , I've merged the PR to this issue , don't worry I'll be updating more beginner issues to my projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants