-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUESTION] Binary search for Carlini-Wagner #167
Comments
Hi @Adversarian , I don’t quite understand something about your expression in According to the README page, if you want to perform a binary search, you can try the following code. atk1 = torchattacks.CW(model, c=0.1, steps=1000, lr=0.01)
atk2 = torchattacks.CW(model, c=1, steps=1000, lr=0.01)
atk = torchattacks.MultiAttack([atk1, atk2]) But this code can't seem to stop early. Well, I tested this code (I am not the maintainer or contributor of this code), and I found that this code does not seem to be able to perform the binary search function it claims. This code only uses one of the attacks to obtain the image, not a binary search. I will submit a version of CW's binary search as soon as possible |
Hi @rikonaka, thank you for your prompt response. Regarding your confusion, I am currently using I understand that a binary search with CW is not very difficult to implement but I simply don't have to time at the moment to submit my own PR so I would immensely appreciate it if you could make it happen. |
Good news 😉, I just spent two hours implementing the CW with binary search, and soon you can use it in |
I am very much obliged. Thank you so much. I'm gonna optimistically close this now! |
❔ Any questions
Hi! First I would like to thank you for your tremendous work on this project. I had a question regarding the CW attack.
In the README page of the project a section under "Getting Started" mentions "Binary search for CW" whereas the documentation states that binary search over
c
was not implemented because it is time consuming. This has left me confused because if there is a way to perform binary search overc
using this library, I would like to know so I can stop using multiple libraries and if not, then what is the subsection under "Getting Started" referring to?The text was updated successfully, but these errors were encountered: