Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fixing and new feature #64

Closed
wants to merge 10 commits into from
Closed

Bug Fixing and new feature #64

wants to merge 10 commits into from

Conversation

Dasemu
Copy link
Contributor

@Dasemu Dasemu commented Oct 23, 2021

Description

  • Fixes Voice changing doesnt work. #63
  • Now it checks if the machine has an internet connection so it will not return exceptions when it tries to recognize the voice.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

@Dasemu
Fixed two problems.
19b407e 
First of all i fixed #25  by adding a fast internet connection check so it doesnt throw exceptions every time if no internet connection. Also fixed a bug that i involuntary created in #34. Now its possible to change voices with `change voice to male/female` command.
@Dasemu
erratum fixed
4de72f7 
couldnt --> couldn't
@Dasemu
Update Jarvis2_4windows.py
0a2e7ed
@Dasemu
Merge branch 'main' of git://github.com/Harsha200105/DesktopAssistant…
5958ea6 
… into Harsha200105-main
@Dasemu
Merge pull request #5 from TallGorilla/Harsha200105-main
1b23918 
Fetch upstream
@Dasemu
Merge pull request #6 from Jothin-kumar/issue_52
49adc9f 
Update gui.py
@Dasemu
Merge branch 'main' of git://github.com/Harsha200105/DesktopAssistant
0218970
@Dasemu
x
352c134
@Dasemu
Merge branch 'main' of https://github.com/TallGorilla/DesktopAssitant
eb0f134
@Dasemu
Update Jarvis2_4windows.py
d27189f
@Dasemu Dasemu closed this by deleting the head repository Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Voice changing doesnt work.
1 participant
@Dasemu