Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - data scaling (applicable for ETH ?) #7

Closed
ksachdeva opened this issue Oct 7, 2020 · 10 comments
Closed

Question - data scaling (applicable for ETH ?) #7

ksachdeva opened this issue Oct 7, 2020 · 10 comments

Comments

@ksachdeva
Copy link
Contributor

Hi @karttikeya

I understand the notion of shifting the dataset to have the same origin. You also multiply the trajectories by 1.86.

  • Is this number has any significance?
  • Is it the same hyper-parameter used for ETH as well?

Regards
Kapil

@karttikeya
Copy link
Collaborator

We noticed scaling the data helped slightly with better optimization (note, same effect might be possible by tuning lambda1 & lambda2 instead). To keep other hyperparameters the same, we scaled the ETH trajectories to be on the order of magnitude of SDD trajectories ( about 170 I believe).

@ksachdeva
Copy link
Contributor Author

Ah. I tried to train ETH this morning but no success. Will try this suggestion now to scale the trajectories first.

@ksachdeva
Copy link
Contributor Author

Hi @karttikeya

This is to confirm that indeed 170 does benefit.

Here is a new notebook in which I am training ETH

https://colab.research.google.com/drive/1OdVwL3CM-_f-T3HlHyY3B2IaTDiKmprs?usp=sharing

This notebook has some differences from code in your repository because of the data preparation part. Everything is in the notebook itself including downloading of datasets etc.

Above to reproduce similar results as paper. Some of the runs produced even a better number.

Would appreciate if you have a cursory look to see I am not doing anything wrong as even though I managed to reproduce your numbers with machine learning it is easy to get fooled.

Again I want to thank you for the time you spent answering the questions; I am very happy that the results of your paper can be reproduced. This is an achievement in itself and indeed a good job on your part and your co-authors.

Regards
Kapil

@HarshayuGirase
Copy link
Owner

Hi @ksachdeva,

That's nice that you were able to reproduce it! I took a glance and it looked good to me -- perhaps this might be useful to add to our repo for others training on UTH/ECY. If you'd like to add a PR with this notebook, we'd be happy to include it.

@ksachdeva
Copy link
Contributor Author

Thanks @HarshayuGirase, I will send the PR tonight.

@karttikeya
Copy link
Collaborator

Thank you for your contribution. I'm closing this issue for now. Please feel free to open another issue for other questions, star the repo if you found it helpful and thanks for interest in our code.

@sjtuxcx
Copy link

sjtuxcx commented Feb 13, 2021

@ksachdeva Hi, May I ask how you generate the eth npz file? I use my eth data but receive a poor performance and I notice there are 30000+ trajectories in your dataset but only 3000+ trajectories in my eth data. Could you share the data generation code?

@SaoDiSengA
Copy link

hi,can you provide the other npz file?Or the processing script!Thanks a lot!

@SaoDiSengA
Copy link

@ksachdeva Hi, May I ask how you generate the eth npz file? I use my eth data but receive a poor performance and I notice there are 30000+ trajectories in your dataset but only 3000+ trajectories in my eth data. Could you share the data generation code?

hi,i got the same question,do you solve the problem?

@SaoDiSengA
Copy link

@ksachdeva Could you share the data generation code?i want to generate the npz file,but i can't solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants