Bug on hidesBarsOnTap

[Bronko44]

Hello Harshil Shah! Thanks a lot of what are you doing!!
In ios11 I found interesting bug. On hiding navigation bar on tap it disappears like on foto. Can you help with this?

[Bronko44]

It works good on version 0.4, but now don't

[HarshilShah]

Sorry for the delay in the response.

I think I might have a solution here, but since I don't have access to your code I'm gonna need some help.

Could you let me know if adding scrollViewUpdater = nil right after this line here https://github.com/HarshilShah/DeckTransition/blob/master/Source/DeckPresentationController.swift#L583 solves the issue for you?

[Bronko44]

I use standard QuickLook library(QLPreviewController) to open files. And this QLPreviewController have default set "hide bars on tap". When I tap on image navigation bar disappears(he moves up through the black area, It seems that the position of the navigation bar is incorrect when hiding) and this func
@objc private func handlePan(gestureRecognizer: UIPanGestureRecognizer) is not called at all.
Unfortunately this line of code did not help.

[HarshilShah]

Hmm, interesting. Could you possibly upload a minimal demo project by modifying the example app to reproduce your issue?

[Bronko44]

Yeah sure, here is example:
https://github.com/Bronko44/example

[HarshilShah]

Thank you so much for the example project!

So the issue here is that since navigation controllers are usually presented fullscreen, they just translate the bars directly with no clipping. Fortunately there's a simple solution for this.

In the DetailsVC, if you use the following line, it will clip the navigation bar's contents:

navigationController?.view.clipsToBounds = true

Clipping has a performance cost sometimes, depending on exactly what drawing is going on, so I'd suggest toggling it with caution, but it does indeed make the animation look as you want it to.

[Bronko44]

Thanks a lot, this solved the problem. And thanks for a detailed explanation to, I appreciate it!