Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal not appearing in segue #60

Closed
g30r93g opened this issue Feb 14, 2018 · 8 comments
Closed

Modal not appearing in segue #60

g30r93g opened this issue Feb 14, 2018 · 8 comments

Comments

@g30r93g
Copy link

g30r93g commented Feb 14, 2018

Hi there.

Really want to use DeckTransition but it isn't working for me.
I'm using a dark background and an embedded UIView with a tap gesture recogniser.

Please can you help me.
@g30r93g
Copy link
Author

g30r93g commented Feb 14, 2018 •
edited

Here are some screenshots of my code.
screen shot 2018-02-14 at 00 46 35
screen shot 2018-02-14 at 00 46 48

@HarshilShah
Copy link
Owner

HarshilShah commented Feb 14, 2018 •
edited

What exactly do you mean by "DeckTransition not working"? What's not working with the transition here?

@g30r93g
Copy link
Author

g30r93g commented Feb 14, 2018

Those lines of code are from your example app which works. However, when I want to present it in my app, it will just push back the OrderViewController. It doesn't display the LargeOrderViewController

@HarshilShah
Copy link
Owner

Could you post screenshots of what you're seeing when you call present with and without the DeckTransitioningDelegate?

@g30r93g
Copy link
Author

g30r93g commented Feb 14, 2018

Without DeckTransitioningDelegate:
fullsizeoutput_179b

With DeckTransitioningDelegate:
fullsizeoutput_179c

@g30r93g g30r93g changed the title DeckTransition not working 😭 DeckTransition - update storyboard documentation Feb 14, 2018
@g30r93g
Copy link
Author

g30r93g commented Feb 14, 2018

I've got it. Needed to conform a segue to DeckSegue. Couldn't find it in the docs so please update for others!

@g30r93g g30r93g closed this as completed Feb 14, 2018
@HarshilShah
Copy link
Owner

Glad the issue is solved. It's already covered in the docs fwiw

@HarshilShah HarshilShah mentioned this issue Mar 23, 2018
Closed
@HarshilShah HarshilShah changed the title DeckTransition - update storyboard documentation Modal not appearing in segue Mar 24, 2018
@HarshilShah
Copy link
Owner

Renamed this to make searching easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HarshilShah @g30r93g