Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete Tabs #13

Closed
jarydkrish opened this issue Dec 13, 2017 · 1 comment
Closed

Complete Tabs #13

jarydkrish opened this issue Dec 13, 2017 · 1 comment

Comments

@jarydkrish
Copy link
Member

Right now tabs don't really do anything.

We should probably change that. One of the examples we could take inspiration from is the concept of TabContent and TabPane from the reactstrap project.

It works by using context, which allows us to add a visible or active css class based on the state of the parent.

All tab content should be rendered on the page, even if the tab isn't visible. No rendering null.

@humphreyja
Copy link
Member

closing in favor for tab switcher components. Not quite as much magic but gets the job done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants