Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stage 2/gossip.rb - every(3.seconds): #1

Closed
wuhl opened this issue Oct 22, 2017 · 0 comments
Closed

stage 2/gossip.rb - every(3.seconds): #1

wuhl opened this issue Oct 22, 2017 · 0 comments

Comments

@wuhl
Copy link
Contributor

wuhl commented Oct 22, 2017

Some issues I found:

  • next if port == PORT missing
  • update_state(JSON.load(gossip_response), port: port) to be switched to update_state(JSON.load(gossip_response))
  • Faraday::ConnectionError to be switched to Faraday::ConnectionFailed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wuhl