Shortened output and function change #16
Conversation
|
Hey! Thanks so much for this PR! Let me checkout and try it. The problem with line by line is: The least likely possible appears on the terminal screen, whereas the user has to scroll up to see the most likely. Whereas currently: (Note: Same terminal size) I wanted least likely to be a small dump of everything possible, but most likely to contain the actual useful information. If I could, I'd get rid of least likely but you never know -- it could be If you input a file, you'll end up with so many lines your terminal may just cut them off 😂 The rest of the PR is 100% fine though, thank you so much for contributing! :D The name changes to HC and JtR will make the big blob of text much smaller 🤍 PS: Nice to see the Docker image is working! It's on my todo list to upload to Dockerhub ✍️ |
|
@all-contributors please add @digitalsleuth for code |
|
I've put up a pull request to add @digitalsleuth! 🎉 |
|
Thank you <3 <3 <3 :D Are you in our Discord? |
|
You're welcome! I'm not in the Discord yet, but it seems like something I should do :) You should see me there shortly! |
Took a look at the issue raised by @delishouscake (#12) and thought I would combine their thoughts into a pull request to make your work a little easier.
This puts every 'Least Likely' on a separate line, vice a long long of hashes, also removed the period at the end of each as a delimiter is no longer necessary at the end of the line.
Additionally, separated the hash identifier and the hash category with a
-for easier reading.Did not change the colors, as I believe that's more within your purview than mine.
Also, renamed the 'greppable' function to 'grepable' for spelling, and corrected all references to it in the other modules/sections of the tool.
Using the example md5 in the help, final output looks like this:
(keep in mind, this is in a docker environment, colors are not indicative of a normal running shell):
Hopefully this helps!