Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'base64' in self.kwargs is always True #52

Closed
glozanoa opened this issue Mar 8, 2021 · 1 comment · Fixed by #54
Closed

'base64' in self.kwargs is always True #52

glozanoa opened this issue Mar 8, 2021 · 1 comment · Fixed by #54

Comments

@glozanoa
Copy link

glozanoa commented Mar 8, 2021

if "base64" in self.kwargs:

'base64' in self.kwargs is always True, no matter that the value of the 'base64' key in self.kwargs dictionary is False or True.

@bee-san
Copy link
Member

bee-san commented Mar 9, 2021

All of our tests fail with just that code change, so I've updated it to feature an "and" :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants