Update Dockerfile for nth vice ciphey #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! Thanks so much for that! Ciphey is my other tool and I copied/pasted it hoping for it to work :) <3 |
|
No problem! Big fan of ciphey, looking forward to using this as well 🙂
…________________________________
From: Brandon <notifications@github.com>
Sent: Saturday, January 30, 2021 8:55 PM
To: HashPals/Name-That-Hash <Name-That-Hash@noreply.github.com>
Cc: Corey Forman <corey@digitalsleuth.ca>; Author <author@noreply.github.com>
Subject: Re: [HashPals/Name-That-Hash] Update Dockerfile for nth vice ciphey (#8)
Wow! Thanks so much for that! Ciphey is my other tool and I copied/pasted it hoping for it to work :) <3
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#8 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AO7OHXWOXHLJ7EAMDKDBII3S4S2CZANCNFSM4W22RVXQ>.
|
|
Hey @digitalsleuth , just some boring legal stuff. We were previously under NOLICENSE, now we're under GNU General Public License v3.0 which is in line with HashID and Hash-Identifier. This is just to ask if you mind at all? This is still a 100% open source project, just we've finally gotten a license :D https://github.com/HashPals/Name-That-Hash/blob/main/LICENSE |
|
Don't mind at all! Happy to help out :) |
|
Oh, and I updated your license in REMnux as well. Lenny will likely merge the changes in the next day or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous dockerfile entrypoint was pointed at 'ciphey' vice 'nth'. Corrected this, and removed the 'CMD' at the bottom.
Tested with
sudo docker run --rm -it nth:latest --text '5f4dcc3b5aa765d61d8327deb882cf99'and with--greppableand had success with both commands.