Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minor bugs. #12

Closed
Ouwen opened this issue Nov 12, 2018 · 2 comments
Closed

Some minor bugs. #12

Ouwen opened this issue Nov 12, 2018 · 2 comments

Comments

@Ouwen
Copy link

Ouwen commented Nov 12, 2018

  • weight init
    In the original paper, he initialization is used instead of xavier, this would translate to using: tf.contrib.layers.variance_scaling_initializer
  • max pooling
    In the original paper, the transition down should be a 2x2 max pool that is non-overlapping. Checking the original Lasagne code it seems they use a 2x2 max pool with a window of 2x2 and stride of 2x2. Wasn't sure if your current 4x4 window as intentional.

Great work on this btw, very readable!

@Ouwen
Copy link
Author

Ouwen commented Nov 12, 2018

x = tf.nn.max_pool(x, [1, 4, 4, 1], [1, 2, 2, 1], padding='SAME', name=name+'_maxpool2x2')

vs original code

@Ouwen Ouwen changed the title Non-overlapping maxpool Some minor bugs. Nov 12, 2018
@HasnainRaz
Copy link
Owner

Thank you for the feedback.

Yeah sorry about those, I made this because of a project I was working on, so I may have changed the pooling window and weight inits. Good catch, I'll restore them to the originals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants