Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check version script is not validating if the release candidate versions is the same for iOS #375

Closed
pedroferreira1 opened this issue Nov 1, 2023 · 0 comments · Fixed by #406
Assignees
Labels
enhancement New feature or request

Comments

@pedroferreira1
Copy link
Member

We have a script that runs in the CI to check if all versions are equal among all files that have them, e.g., package.json, build.gradle, and project.pbxproj.

However, for the iOS version, we only validate the first part of the version, without the release candidate number (rcX).

The script validates only if the release candidate number is in a valid format, i.e., [0-9].[0-9].[0-9].

We must improve the script to validate that this format matches the other versions' release candidate number, and, if it's not a release candidate, if the format is 1.0.0, as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants