Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About screen error handling when build version is incorrect #378

Closed
tuliomir opened this issue Nov 6, 2023 · 0 comments · Fixed by #397
Closed

About screen error handling when build version is incorrect #378

tuliomir opened this issue Nov 6, 2023 · 0 comments · Fixed by #397
Assignees
Labels
bug Something isn't working

Comments

@tuliomir
Copy link
Contributor

tuliomir commented Nov 6, 2023

When the build version is incorrect, the About screen throws an unhandled error. This is related to the code below:

if (build.length !== 3) {
throw new Error('IOS build version is not in the correct format.');
}

Instead of throwing, the desired outcome would be to have the incorrect build version followed by (Parse Error)

Reproducing steps

It was not possible, as of now, to reproduce this error on the simulator environment: it only happens when two releases are made to the TestFlight without changing neither the MARKETING_VERSION nor the CURRENT_PROJECT_VERSION on the ios/project.pbxproj file.

What follows is an attempt to inform the version values 0.26.0(1) and 0.7.0(1) to these variables:

Simulator Screenshot - iPhone 13 mini - 2023-11-06 at 11 42 02

Proposed solutions

A solution was offered to solve this on branch fix/about-version-err, but was unable to be tested because this error only seems to happen when actually making incorrect deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant