Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging #3

Open
andreabadesso opened this issue Apr 22, 2021 · 2 comments
Open

Improve logging #3

andreabadesso opened this issue Apr 22, 2021 · 2 comments

Comments

@andreabadesso
Copy link
Collaborator

Currently we are using console.log to log errors, we should improve our logging mechanism and maybe use Sentry to warn us about reorgs or critical errors

#1 (comment)

@andreabadesso
Copy link
Collaborator Author

@luislhl

We are not using console.log anymore but are yet to send logs to Sentry, should we still do it or should we just log away and let whatever is monitoring the logs alert us?

@luislhl
Copy link
Collaborator

luislhl commented Jul 1, 2021

@luislhl

We are not using console.log anymore but are yet to send logs to Sentry, should we still do it or should we just log away and let whatever is monitoring the logs alert us?

Sentry is not a logging solution, so we shouldn't send all logs to it. We should send any logs to stdout, and some logging mechanism will capture them and send somewhere else.

Besides that, I think we should also send error logs to Sentry, because it will aggregate the errors for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants