Enables GIT_REPOs with other protocols (http instead of https)
#3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh shoot, I just realized you did the changes on |
|
I was only able to change the target branch to next. Is this enough? Where do I find the review? |
DonMartin76
reviewed
Jul 7, 2017
bin/create-git-url.sh
Outdated
| echo "Assuming public repository, GIT_CREDENTIALS is empty" | ||
| GIT_URL=${protocol}://${repo} | ||
| fi | ||
|
|
There was a problem hiding this comment.
I really like this approach; may I just nitpick and ask you to make the indentation correct?
There was a problem hiding this comment.
My bad, I didn't submit the review :-(
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am talking about the git url which is used to load the static config. I changed the creation of said url in a way that you now have to option to define it with an optional prefixed protocol.
It is now possible to define
GIT_REPOas:The protocol is going to be respected or respectively added to the URL.
I also created a bash script for tests which is run whenever the unit tests are run. But I just learned that
run-unit-tests.shis deprecated, so you probably want to change the way the script is executed. I was unable to find the right place.