Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port: Display of Kotlin enums messages #204

Closed
artemglinov opened this issue Jul 2, 2021 · 4 comments
Closed

Port: Display of Kotlin enums messages #204

artemglinov opened this issue Jul 2, 2021 · 4 comments
Assignees
@artemglinov @maistrenkoIulia
Labels
type: port
Milestone
1.1.0

Comments

@artemglinov
Copy link
Contributor

cuba-platform/cuba#3156
@artemglinov artemglinov added this to the 1.1.0 milestone Jul 2, 2021
@artemglinov artemglinov self-assigned this Jul 2, 2021
@artemglinov artemglinov changed the title Port: Display Kotlin enums messages Port: Display of Kotlin enums messages Jul 2, 2021
artemglinov added a commit to jmix-projects/jmix-cuba that referenced this issue Jul 5, 2021
@artemglinov
Port: Display of Kotlin enums messages jmix-framework/jmix#204
5790ecb
artemglinov added a commit to jmix-projects/jmix-cuba that referenced this issue Jul 5, 2021
@artemglinov
Add the fix port to MessagesImpl (jmix-core module) jmix-framework/jm…
51e97f4 
…ix#204
artemglinov added a commit that referenced this issue Jul 5, 2021
@artemglinov
Add the fix port to MessagesImpl (jmix-core module) #204
32fa719
artemglinov added a commit to jmix-projects/jmix-cuba that referenced this issue Jul 6, 2021
@artemglinov
Port: Display of Kotlin enums messages jmix-framework/jmix#204
008f90b
artemglinov added a commit that referenced this issue Jul 6, 2021
@artemglinov
Port: Display of Kotlin enums messages #204
e6be14b
@artemglinov
Copy link
Contributor Author

artemglinov commented Jul 6, 2021 •
edited

QA Notes

Test only the correctness of Java enums messages display because Kotlin enums are not supported in Jmix yet.

@maistrenkoIulia
Copy link

kotlin is already supported by jmix
Jmix version: 1.1.0-SNAPSHOT
Jmix Studio plugin version: 1.1.SNAPSHOT3391-211
IntelliJ version: IntelliJ IDEA 2021.2 (Ultimate Edition)
kotenum.zip

image

@artemglinov
Copy link
Contributor Author

artemglinov commented Aug 10, 2021 •
edited

@maistrenkoIulia Set the messages for the enum entries (not only for the enum TaxType itself) in the attached project according to the Studio warnings. I've tried it, and it works.

@maistrenkoIulia
Copy link

verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@artemglinov artemglinov

@maistrenkoIulia maistrenkoIulia

Labels
type: port
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@artemglinov @maistrenkoIulia @lovtsovaik