Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AttributeChanges and EntityAttributeChanges #72

Closed
dtaimanov opened this issue Feb 1, 2021 · 1 comment
Closed

Refactor AttributeChanges and EntityAttributeChanges #72

dtaimanov opened this issue Feb 1, 2021 · 1 comment
Assignees
@andreysubbotin
Milestone
0.9.0

Comments

@dtaimanov
Copy link
Contributor

There are two similar classes in Jmix:

  1. io.jmix.core.event.AttributeChanges
  2. io.jmix.data.impl.EntityAttributeChanges

Second class does almost the same as first, but also provides extra functionality: e.g. get changes from eclipselink's AttributeChangeListener, work with dynamic attributes [in progress]

Proposition

  1. Make EntityAttributeChanges extend AttributeChanges to get rid of code duplication
  2. Rename EntityAttributeChanges to something like PersistentAttributeChanges / EclipselinkAttributeChanges
@dtaimanov dtaimanov self-assigned this Feb 1, 2021
@andreysubbotin andreysubbotin added this to the 1.0.0 milestone Feb 26, 2021
@andreysubbotin
Copy link
Contributor

Fixed in jmix-projects/jmix-data#46

@knstvk knstvk mentioned this issue Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreysubbotin andreysubbotin

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@andreysubbotin @dtaimanov