Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

Unnecessary @StudioAction in reporting actions #51

Closed
alexbudarov opened this issue Mar 6, 2021 · 0 comments
Closed

Unnecessary @StudioAction in reporting actions #51

alexbudarov opened this issue Mar 6, 2021 · 0 comments
Assignees
@m-orlova
Labels
type: bug Something isn't working
Milestone
1.0.0

Comments

@alexbudarov
Copy link

alexbudarov commented Mar 6, 2021 •
edited

Problem:
Currently in Studio (action creation dialog in table context) a lot of Reporting actions are displayed that are not designed to work with table:
image

  1. io.jmix.reportsui.action.list.EditViewAction action isn't meant to be used globally outside of Report Editor.
    Therefore it shouldn't be marked with @StudioAction

  2. io.jmix.reportsui.action.list.TablePrintFormAction
    2.1) It doesn't work (fail with exception) if you try to add it to the table:

Caused by: java.lang.NoSuchMethodException: io.jmix.reportsui.action.list.TablePrintFormAction.<init>(java.lang.String)
	at java.base/java.lang.Class.getConstructor0(Class.java:3349) ~[na:na]
	at java.base/java.lang.Class.getConstructor(Class.java:2151) ~[na:na]
	at io.jmix.ui.sys.ActionsImpl.createAction(ActionsImpl.java:113) ~[jmix-ui-1.0.0-SNAPSHOT.jar:na]

2.2) Action description is wrong (talks about editor screen)

  1. Please decide just one action that should be shown to Studio users: either TablePrintFormAction or ListPrintFormAction.
    As I understand, they are identical.
    Remove @StudioAction annotation from other action.

see for information:
@alexbudarov alexbudarov added this to the 1.0.0 milestone Mar 6, 2021
@alexbudarov alexbudarov added the type: bug Something isn't working label Mar 6, 2021
@alexbudarov alexbudarov changed the title Remove @StudioAction from EditViewAction Unnecessary @StudioAction in reporting actions Mar 6, 2021
@gorbunkov gorbunkov modified the milestones: 0.9.0, 1.0.0 Mar 19, 2021
@gorbunkov gorbunkov self-assigned this Apr 26, 2021
@gorbunkov gorbunkov assigned m-orlova and unassigned gorbunkov May 26, 2021
m-orlova pushed a commit that referenced this issue May 28, 2021
Unnecessary @StudioAction in reporting actions #51
9597641 
1. Remove StudioAction annotation from EditFetchPlanAcion
2. Remove TablePrintFormAction because it duplicates ListPrintFormAction
m-orlova pushed a commit that referenced this issue May 31, 2021
Fix liquibase changesets for MySQL/MS SQL databases #51
0883689 
1. Change type for the LOCAL_NAMES column in Report and ReportGroup tables to type as in CUBA add-on
2. Move creation of the FK key for Report in ReportTemplate table from separate changeset to changeset with tables creation
3. Change type for the PARAMS and ERROR_MESSAGE columns in ReportExecution table to types as in CUBA add-on
4. Remove a creation of the unique constraints for NAME (Report table) and TITLE (ReportGroup table) columns because they are incorrect. It will be fixed in the separate ticket (#161)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@m-orlova m-orlova

Labels
type: bug Something isn't working
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
3 participants
@alexbudarov @gorbunkov @m-orlova