Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

User Substitution enhancement #111

Closed
gorbunkov opened this issue Oct 6, 2021 · 3 comments
Closed

User Substitution enhancement #111

gorbunkov opened this issue Oct 6, 2021 · 3 comments
Assignees
@gorbunkov @konyashkina
Milestone
1.1.0

Comments

@gorbunkov
Copy link
Contributor

Some enhancements for #30

  1. Introduce the CurrentUserSubstitution interface. It will be responsible for getting substituted user information. The CurrentAuthetication interface will contain method for getting authenticated user only.
  2. Move UserSubstitutionManager implementation to the core module
  3. Introduce UserSubstitutionProvider interface with 2 implementations: in-memory (jmix-core) and database (jmix-securitydata).
  4. Change the UI component for selecting substituted user from combo-box to suggestion field
  5. Introduce the non-persistent UserSubstitution object.
@gorbunkov gorbunkov added this to the 1.1.0 milestone Oct 6, 2021
@gorbunkov gorbunkov self-assigned this Oct 6, 2021
gorbunkov added a commit to jmix-projects/jmix-translations that referenced this issue Oct 7, 2021
@gorbunkov
User Substitution enhancement jmix-projects/jmix-security#111
a6535e1 
CurrentUserSubstitution interface introduced. It is responsible for getting substituted user information. The CurrentAuthentication interface now contains method for getting authenticated user only;
UserSubstitutionManagerImpl implementation moved to core module;
UserSubstitutionProvider interface introduced with 2 implementations: in-memory (jmix-core) and database (jmix-securitydata);
UI component for selecting substituted user changed from combo-box to suggestion field (in substitution editor);
Non-persistent UserSubstitution object;
gorbunkov added a commit that referenced this issue Oct 7, 2021
@gorbunkov
User Substitution enhancement #111
343ef2d 
CurrentUserSubstitution interface introduced. It is responsible for getting substituted user information. The CurrentAuthentication interface now contains method for getting authenticated user only;
UserSubstitutionManagerImpl implementation moved to core module;
UserSubstitutionProvider interface introduced with 2 implementations: in-memory (jmix-core) and database (jmix-securitydata);
UI component for selecting substituted user changed from combo-box to suggestion field (in substitution editor);
Non-persistent UserSubstitution object;
gorbunkov added a commit to jmix-projects/jmix-graphql that referenced this issue Oct 7, 2021
@gorbunkov
User Substitution enhancement jmix-projects/jmix-security#111
b527f7f 
CurrentUserSubstitution interface introduced. It is responsible for getting substituted user information. The CurrentAuthentication interface now contains method for getting authenticated user only;
UserSubstitutionManagerImpl implementation moved to core module;
UserSubstitutionProvider interface introduced with 2 implementations: in-memory (jmix-core) and database (jmix-securitydata);
UI component for selecting substituted user changed from combo-box to suggestion field (in substitution editor);
Non-persistent UserSubstitution object;
gorbunkov added a commit to jmix-projects/jmix-reports that referenced this issue Oct 7, 2021
@gorbunkov
User Substitution enhancement jmix-projects/jmix-security#111
ff7b675 
CurrentUserSubstitution interface introduced. It is responsible for getting substituted user information. The CurrentAuthentication interface now contains method for getting authenticated user only;
UserSubstitutionManagerImpl implementation moved to core module;
UserSubstitutionProvider interface introduced with 2 implementations: in-memory (jmix-core) and database (jmix-securitydata);
UI component for selecting substituted user changed from combo-box to suggestion field (in substitution editor);
Non-persistent UserSubstitution object;
gorbunkov added a commit to jmix-projects/jmix-rest that referenced this issue Oct 7, 2021
@gorbunkov
User Substitution enhancement jmix-projects/jmix-security#111
477aefb 
CurrentUserSubstitution interface introduced. It is responsible for getting substituted user information. The CurrentAuthentication interface now contains method for getting authenticated user only;
UserSubstitutionManagerImpl implementation moved to core module;
UserSubstitutionProvider interface introduced with 2 implementations: in-memory (jmix-core) and database (jmix-securitydata);
UI component for selecting substituted user changed from combo-box to suggestion field (in substitution editor);
Non-persistent UserSubstitution object;
gorbunkov added a commit to jmix-framework/jmix that referenced this issue Oct 7, 2021
@gorbunkov
User Substitution enhancement jmix-projects/jmix-security#111
bff6572 
CurrentUserSubstitution interface introduced. It is responsible for getting substituted user information. The CurrentAuthentication interface now contains method for getting authenticated user only;
UserSubstitutionManagerImpl implementation moved to core module;
UserSubstitutionProvider interface introduced with 2 implementations: in-memory (jmix-core) and database (jmix-securitydata);
UI component for selecting substituted user changed from combo-box to suggestion field (in substitution editor);
Non-persistent UserSubstitution object;
gorbunkov added a commit to jmix-projects/jmix-ui that referenced this issue Oct 7, 2021
@gorbunkov
User Substitution enhancement jmix-projects/jmix-security#111
10d71d3 
CurrentUserSubstitution interface introduced. It is responsible for getting substituted user information. The CurrentAuthentication interface now contains method for getting authenticated user only;
UserSubstitutionManagerImpl implementation moved to core module;
UserSubstitutionProvider interface introduced with 2 implementations: in-memory (jmix-core) and database (jmix-securitydata);
UI component for selecting substituted user changed from combo-box to suggestion field (in substitution editor);
Non-persistent UserSubstitution object;
gorbunkov added a commit to jmix-framework/jmix that referenced this issue Oct 7, 2021
@gorbunkov
User Substitution enhancement jmix-projects/jmix-security#111
b39c32f 
Fix javadoc
@gorbunkov gorbunkov mentioned this issue Oct 7, 2021
Closed
gorbunkov added a commit that referenced this issue Oct 7, 2021
@gorbunkov
User Substitution enhancement #111
6cd269c 
Substituted user field in substitution editor is required
@lovtsovaik
Copy link

@gorbunkov please provide QA notes for testing the issue

@gorbunkov
Copy link
Contributor Author

For QA: we need to check that methods of CurrentUserSubstitution interface return correct values.

@lovtsovaik lovtsovaik assigned konyashkina and unassigned lovtsovaik Oct 7, 2021
@dtaimanov dtaimanov mentioned this issue Oct 7, 2021
Closed
17 tasks
@konyashkina
Copy link

Tested on
Jmix version: 1.1.0-SNAPSHOT
Jmix Studio plugin version: 1.1.SNAPSHOT3625-212
IntelliJ version: IntelliJ IDEA 2021.2.2 (Ultimate Edition)

gorbunkov added a commit to jmix-framework/jmix that referenced this issue Oct 19, 2021
@gorbunkov
CurrentAuthentication - unused current user method removed jmix-proje…
98fd493 
…cts/jmix-security#111
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gorbunkov gorbunkov

@konyashkina konyashkina

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
3 participants
@gorbunkov @lovtsovaik @konyashkina