Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

PivotExcelExporter should apply styling for Double and Integer cells in exported file #479

Closed
Flaurite opened this issue May 24, 2021 · 1 comment
Assignees
Milestone

Comments

@Flaurite
Copy link
Contributor

Flaurite commented May 24, 2021

Changes

Double and Integer values from PivotTable now apply Datatype formatting.

Breaking Changes
PivotDataCell.Type enum has changed values from:

STRING, NUMERIC, DATE_TIME, DATE, TIME

To

STRING, INTEGER, DECIMAL, DATE_TIME, DATE, TIME

To configure decimal format you can use the following keys:

  • decimalFormat - used in the application to format visible values, default value: #,##0.##
  • pivotExcelExporter.doubleFormat - used as cell style in the excel, default value: #,##0.00##############

QA

Test with EN and RU locales

Output before fix:
6.47225834416992
Output after:
6.67

@Flaurite Flaurite self-assigned this May 24, 2021
@glebfox glebfox added the type: bug Something isn't working label Jul 6, 2021
@glebfox glebfox added this to the 1.1.0 milestone Jul 6, 2021
@Flaurite Flaurite removed the type: bug Something isn't working label Jul 29, 2021
Flaurite added a commit to jmix-projects/jmix-translations that referenced this issue Aug 2, 2021
Flaurite added a commit that referenced this issue Aug 2, 2021
@lovtsovaik lovtsovaik assigned konyashkina and unassigned lovtsovaik Aug 13, 2021
Flaurite added a commit that referenced this issue Aug 17, 2021
…in exported file #479

Fixed non-editable PivotTable
@konyashkina
Copy link

Tested on
Jmix version: 1.1.0-SNAPSHOT
Jmix Studio plugin version: 1.1.SNAPSHOT3442-211
IntelliJ version: IntelliJ IDEA 2021.1.3 (Community Edition)

Verified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants