Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

Fix style for sidemenu with activated selectOnClick attribute in the main screen with collapsible menu template #652

Closed
sukhova opened this issue Sep 9, 2021 · 2 comments
Closed

Fix style for sidemenu with activated selectOnClick attribute in the main screen with collapsible menu template #652

sukhova opened this issue Sep 9, 2021 · 2 comments
Assignees
@Flaurite @reznikova21
Labels
type: bug Something isn't working
Milestone
1.1.0

Comments

@sukhova
Copy link

sukhova commented Sep 9, 2021 •
edited by Flaurite

Test case:

  1. Create a main screen with collapsible side menu
  2. Set selectOnClick="true"
  3. Launch the application

AR:
Halo theme:
side-menu-select-click-halo.gif
Helium theme
side-menu-select-click-helium.gif
Hover theme - the same

ER:
side-menu-select-click-helium-er.gif

Changes

Added new SCSS variables:

  • $jmix-sidemenu-item-selected-background - background of selected item in SideMenu;
  • $jmix-sidemenu-item-selected-color - text color of selected item in SideMenu;
  • $jmix-drawer-sidemenu-item-selected-background - background color of the selected item in SideMenu that is placed in Drawer
  • $jmix-drawer-sidemenu-item-selected-color - color of the selected item in SideMenu that is placed in Drawer
@sukhova sukhova added the type: bug Something isn't working label Sep 9, 2021
@glebfox glebfox assigned Flaurite and unassigned Flaurite Sep 10, 2021
@knstvk knstvk assigned Flaurite and unassigned glebfox Sep 13, 2021
@knstvk knstvk added this to the 1.1.0 milestone Sep 13, 2021
@knstvk
Copy link
Contributor

knstvk commented Sep 13, 2021

Port to 1.0 if needed.

Flaurite added a commit that referenced this issue Oct 4, 2021
@Flaurite
Fix style for sidemenu with activated selectOnClick attribute in the …
5d63362 
…main screen with collapsible menu template #652
@Flaurite Flaurite mentioned this issue Oct 4, 2021
Closed
Flaurite added a commit that referenced this issue Oct 4, 2021
@Flaurite
Fix style for sidemenu with activated selectOnClick attribute in the …
e79be32 
…main screen with collapsible menu template #652

Fixed variable name
@lovtsovaik lovtsovaik assigned reznikova21 and unassigned lovtsovaik Oct 4, 2021
@reznikova21
Copy link

Jmix version: 1.1.0-SNAPSHOT - verified

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Flaurite Flaurite

@reznikova21 reznikova21

Labels
type: bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
6 participants
@knstvk @glebfox @Flaurite @sukhova @lovtsovaik @reznikova21