Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose sound length. #1915

Merged
merged 15 commits into from
Aug 23, 2016
Merged

Expose sound length. #1915

merged 15 commits into from
Aug 23, 2016

Conversation

IBwWG
Copy link
Contributor

@IBwWG IBwWG commented Aug 23, 2016

No description provided.

IBwWG and others added 13 commits April 21, 2016 20:19
@IBwWG
Merge pull request #16 from HaxeFlixel/dev
a197f5c 
Catch up with upstream.
@IBwWG
Merge pull request #22 from HaxeFlixel/dev
262eabb 
FlxTilemapTest: add a basic test for loadMapFromGraphic()
@IBwWG
Merge pull request #24 from HaxeFlixel/dev
2966605 
Catch up with upstream.
@IBwWG
Merge pull request #27 from HaxeFlixel/dev
dedca7c 
Fix VCR to record simultaneous keys+mouse, closes HaxeFlixel#1739 (HaxeFlixel#1825)
@IBwWG
Merge pull request #29 from HaxeFlixel/dev
072baa7 
Catch up with upstream.
@IBwWG
Merge pull request #31 from HaxeFlixel/dev
119aa76 
Catch up with upstream.
@IBwWG
Merge pull request #33 from HaxeFlixel/dev
cbf0dc6 
Catch up with upstream.
@IBwWG
Add function to get sound length.
1015fed
@IBwWG
Merge pull request #38 from IBwWG/gettable-sound-length
f372e05 
Add function to get sound length.
@IBwWG
Revert "Add function to get sound length."
6a8abc0
@IBwWG
Merge pull request #39 from IBwWG/revert-38-gettable-sound-length
675985a 
Revert "Add function to get sound length."
@IBwWG
Add function to get sound length.
941275e
@IBwWG
Integrate length so it doesn't crash during pause, and can be used to…
0ffad77 
… identify sounds.
@Gama11
Copy link
Member

Gama11 commented Aug 23, 2016

Travis is failing:

Class: flixel.system.frontEnds.SoundFrontEndTest x.x
    ERROR: massive.munit.UnhandledException: Invalid field access : get_length at flixel.system.frontEnds.SoundFrontEndTest#testLoadInvalidSoundPathNoCrash at flixel/system/FlxSound.hx (319)
    at flixel/system/frontEnds/SoundFrontEnd.hx (124)
    at flixel/system/frontEnds/SoundFrontEndTest.hx (22)
    at massive/munit/TestRunner.hx (330)
    ERROR: massive.munit.UnhandledException: Invalid field access : get_length at flixel.system.frontEnds.SoundFrontEndTest#testPlayMusicInvalidSoundPathNoCrash at flixel/system/FlxSound.hx (319)
    at flixel/system/frontEnds/SoundFrontEnd.hx (92)
    at flixel/system/frontEnds/SoundFrontEndTest.hx (16)
    at massive/munit/TestRunner.hx (330)

@Gama11 Gama11 added this to the 4.2.0 milestone Aug 23, 2016
@IBwWG
Copy link
Contributor Author

IBwWG commented Aug 23, 2016

Yay Travis! :)

@Gama11
Copy link
Member

Gama11 commented Aug 23, 2016

I'm actually quite surprised that there didn't seem to be a way to obtain the duration previously. Speaking of, maybe duration is a better name than length?

@IBwWG
Copy link
Contributor Author

IBwWG commented Aug 23, 2016 •
edited

I was too :)

If you like. Doesn't make a difference to me--tracks' durations are referred to as "lengths" in media players, generally. Likely used in a music context only, anyway (c.f. https://github.com/IBwWG/flixel/blob/6937618cc2f9cc1c9aa58d75439a343873c94282/flixel/system/FlxSound.hx#L85 where it's assumed to be music if you're using the time field as well.) So actually I would argue for leaving it ;)

@Gama11
Copy link
Member

Gama11 commented Aug 23, 2016

I'd like a third opinion on the naming. :)

@IBwWG
Copy link
Contributor Author

IBwWG commented Aug 23, 2016

OpenFL's opinion? They called it length internally :)

@Gama11
Copy link
Member

Gama11 commented Aug 23, 2016

Not really OpenFL's decision, they just copied the Flash API. ;)

@Gama11
Copy link
Member

Gama11 commented Aug 23, 2016

Btw, do you want an invite to the HaxeFlixel slack? (would need your email)

@IBwWG
Copy link
Contributor Author

IBwWG commented Aug 23, 2016

Indeed...

@IBwWG
Copy link
Contributor Author

IBwWG commented Aug 23, 2016

Sure, that'd be great some time...I will PM you when I'm ready :) thanks!

@Gama11
Copy link
Member

Gama11 commented Aug 23, 2016

PM me? Since when does GitHub have private messages? :)

@IBwWG
Copy link
Contributor Author

IBwWG commented Aug 23, 2016

Well, ya know...the equivalent...I thought it had a way to e-mail another user directly. Hmm, not sure how I contacted the last person from here...

@Gama11
Copy link
Member

Gama11 commented Aug 23, 2016

You can find my email in the commit history. I think the forums have PMs too.

@Gama11 Gama11 merged commit 55c04a8 into HaxeFlixel:dev Aug 23, 2016
Gama11 added a commit that referenced this pull request Aug 23, 2016
@Gama11
FlxSound: some code formatting for #1915
b862951
Aurel300 pushed a commit to larsiusprime/haxeflixel that referenced this pull request Apr 18, 2018
@IBwWG @Aurel300
FlxSound: expose length (HaxeFlixel#1915)
76fdb95
Aurel300 pushed a commit to larsiusprime/haxeflixel that referenced this pull request Apr 18, 2018
@Gama11 @Aurel300
FlxSound: some code formatting for HaxeFlixel#1915
928a34a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IBwWG @Gama11