Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin.xml version does not match package.json version #69

Closed
rtholmes opened this issue Mar 14, 2022 · 3 comments
Closed

plugin.xml version does not match package.json version #69

rtholmes opened this issue Mar 14, 2022 · 3 comments

Comments

@rtholmes
Copy link

The version is not consistent between plugin.xml and package.json:

This causes confusion because:

cordova plugin list
cordova-background-geolocation-plugin 2.0.1 "CDVBackgroundGeolocation"

even though 2.0.3 is installed.

Similarly, the name field is inconsistent between the two files (likely both should be cordova-background-geolocation-plugin, instead of plugin.xml being CDVBackgroundGeolocation).

@HarelM
Copy link
Collaborator

HarelM commented Mar 14, 2022

Hmm... Bummer.
Can you make a PR to fix this and increment to 2.0.4?

@rtholmes
Copy link
Author

@HarelM done in PR #70

@rtholmes
Copy link
Author

One thing I noticed though is that package-lock.json also has a version number in there, and I'm not sure when that is supposed to be incremented.

@HarelM HarelM closed this as completed in 8cd4df9 Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants