Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout logged to console does not print correct parameter value, gets capped #39

Closed
deepumukundan opened this issue Jan 15, 2017 · 1 comment

Comments

@deepumukundan
Copy link

When tried the last sample to badge and shield with a timeout,
badge --shield "Version-0.0.3-blue" --dark --shield_no_resize --verbose --shield_io_timeout 120

I am getting the message below in verbose mode.

INFO [2017-01-15 11:15:04.38]: Start adding badges...
DEBUG [2017-01-15 11:15:04.38]: Trying to load image from shield.io. Timeout: 10s
DEBUG [2017-01-15 11:15:04.38]: URL: https://img.shields.io/badge/Version-0.0.3-blue.png
ERROR [2017-01-15 11:15:14.38]: Error loading image from shield.io timeout reached. Skipping Shield. Use --verbose for more info

  1. The timeout passed in was 120s, not 10, so ideally should print the passed value
  2. Timeout gets capped at 60 seconds, even though a larger value was passed in, so maybe an error or message could be printed on console stating that max allowed is 60.

version : badge 0.7.1

@HazAT
Copy link
Owner

HazAT commented Jan 20, 2017

#38 Duplicate

@HazAT HazAT closed this as completed Jan 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants