Skip to content
This repository has been archived by the owner on Jun 1, 2022. It is now read-only.

Prevent creating empty objects #27

Closed
erinknight242 opened this issue Sep 17, 2019 · 0 comments
Closed

Prevent creating empty objects #27

erinknight242 opened this issue Sep 17, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request javascript Pull requests that update Javascript code .NET Pull requests that update .net code
Projects

Comments

@erinknight242
Copy link
Collaborator

When you delete all child rows from an object from the modal window, it appropriately disables the "Update Model" button to prevent you from saving an object with no children.
image

However, if you edit a nested field (or model) from the root grid and delete it, it leaves an empty object if it was the only child of its parent. This is probably OK, because it would be frustrating to not be able to delete a row that you're trying to delete just because of how you got to the row. If we don't want to disable deleting only children for that reason, then we need to add some validation that would prevent you from saving a contract with an empty object.

@erinknight242 erinknight242 added enhancement New feature or request .NET Pull requests that update .net code javascript Pull requests that update Javascript code labels Sep 17, 2019
@erinknight242 erinknight242 added this to To do in Development Sep 19, 2019
@saa14 saa14 moved this from To do to In progress in Development Sep 23, 2019
@saa14 saa14 self-assigned this Sep 23, 2019
@erinknight242 erinknight242 moved this from In progress to Review in progress in Development Oct 16, 2019
@najeraz najeraz moved this from Review in progress to Ready for Review in Development Nov 15, 2019
@najeraz najeraz moved this from Ready for Review to Review in progress in Development Nov 19, 2019
najeraz added a commit that referenced this issue Nov 19, 2019
…ng_empty_objects

Feature/#27 prevent creating empty objects
@najeraz najeraz moved this from Review in progress to Merged to Dev in Development Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request javascript Pull requests that update Javascript code .NET Pull requests that update .net code
Projects
Development
  
Merged to Dev
Development

No branches or pull requests

3 participants