Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-square textures #122

Closed
jleclanche opened this issue Aug 5, 2016 · 3 comments
Closed

Handle non-square textures #122

jleclanche opened this issue Aug 5, 2016 · 3 comments
Labels
wontfix This will not be worked on

Comments

@jleclanche
Copy link
Member

jleclanche commented Aug 5, 2016 •
edited

Joust shouldn't assume square textures.

image

https://hsreplay.net/replay/avHw7bMDcbARKjfQxA47cm#turn=31a
@jleclanche jleclanche mentioned this issue Aug 5, 2016
Closed
@beheh
Copy link
Member

beheh commented Aug 6, 2016

There's really no simple fix for this, it's extremely tricky to maintain aspect ratio and crop images if we can't rely on them being square, portrait or landscape. Will probably not happen until we have a Javascript-based card renderer.

@jleclanche
Copy link
Member Author

Alright, well I'm now generating 512x and 256x thumbnails which guarantee squareness.

Also, blizzard squareified the texture :)

@beheh
Copy link
Member

beheh commented Aug 31, 2016

👍

Closing for now, since it's not really feasible with the current renderer.

@beheh beheh closed this as completed Aug 31, 2016
@beheh beheh added the wontfix This will not be worked on label Sep 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix This will not be worked on
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jleclanche @beheh