Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card text scales with viewport height, rather than applet size #53

Closed
andburn opened this issue Mar 9, 2016 · 4 comments
Closed

Card text scales with viewport height, rather than applet size #53

andburn opened this issue Mar 9, 2016 · 4 comments
Assignees
@beheh
Labels
bug Something isn't working

Comments

@andburn
Copy link
Member

andburn commented Mar 9, 2016

Scaling the whole card component with a css transform seems like best solution. The percentage based text alignment isn't very accurate anyway.

Depends somewhat on the decision of #51.
@andburn andburn self-assigned this Mar 9, 2016
@andburn andburn mentioned this issue Mar 9, 2016
Closed
@beheh
Copy link
Member

beheh commented Mar 9, 2016

I'm working on this right now.

@beheh beheh assigned beheh and unassigned andburn Mar 9, 2016
@beheh
Copy link
Member

beheh commented Mar 9, 2016

I won't be able to finish this tonight, but I'm reworking the full CSS. The main problem was using the vh size parameter - it's relative to the viewport height, not the container height. We might have to fallback to FitText or something.

@andburn
Copy link
Member Author

andburn commented Mar 9, 2016

Ok, sure. Won't touch any of it until your finished 😄

@beheh beheh added wip bug Something isn't working labels Mar 21, 2016
@beheh beheh added this to the v1.0 milestone Mar 21, 2016
@beheh
Copy link
Member

beheh commented Apr 6, 2016

This is no issue right now with the new layout.

@beheh beheh closed this as completed Apr 6, 2016
@beheh beheh removed the wip label Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beheh beheh

Labels
bug Something isn't working
Milestone
No milestone
Development

No branches or pull requests
2 participants
@beheh @andburn