Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul services bundle ? #55

Closed
freeseacher opened this issue Oct 14, 2020 · 3 comments
Closed

consul services bundle ? #55

freeseacher opened this issue Oct 14, 2020 · 3 comments

Comments

@freeseacher
Copy link
Contributor

Hi, don't you think it is a good idea to bundle in
https://heavyhorst.github.io/remco/plugins/consul-plugin-example/ ?

code here is allredy outdated there is no "github.com/HeavyHorst/remco/backends/plugin"

@HeavyHorst
Copy link
Owner

Oh you're right.

It's github.com/HeavyHorst/remco/pkg/backends/plugin

The example is here: https://github.com/HeavyHorst/remco/blob/master/docs/content/plugins/consul-plugin-example.md

@freeseacher
Copy link
Contributor Author

Yep. I've found it.

I recently have several conversations about plugins in docs and know several persons confused with plugin code in docs.
It should probably be in the main repo and build during release and placed somewhere near release binary.

Don't you think so?

@HeavyHorst
Copy link
Owner

Well, the consul support is in the main repo (easykv) this was just an example to show how you could write your own plugin.

Additional plugins could be of course in the main repo. Good Idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants