Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched display values to menu buttons #1

Merged
merged 3 commits into from Jan 24, 2022
Merged

Switched display values to menu buttons #1

merged 3 commits into from Jan 24, 2022

Conversation

BlackPhlox
Copy link
Contributor

@BlackPhlox BlackPhlox commented Jan 24, 2022

Switched to a togglable structure:
image

Currently unable to make the context menus be at bottom_panel with egui bottom_up layout direction [ie. Mode, Size/Res, VSync, Msaa], so currently the top_panel is used until the layout has been resolved.

Other changes:

  • Added MsaaSetting enum with EnumIter and comment on the current limitation of samples and using cfg for future usages and supportability
  • Since FRAME_TIME is already created in FrameTimeDiagnosticsPlugin, this has also been added as a display value.
  • Reduced resolution formatting to a single format!()
  • Added On an Off for VSync instead of displaying boolean value

@heavyrain266
Copy link
Owner

Thanks, looks really good, recently discovered that wgpu support only MSAA 1x (off) and 4x but I heard thst they're having plans for adding support for more samples to wgpu-native, modern GPUs support up to 16x and Nvidia Quadro up to 32x

@BlackPhlox
Copy link
Contributor Author

Yup yup, When the times come, I'm not quite sure how we could only show the valid settings depending on GPUs, but I'm guessing wgpu will detect which GPU you have and expose an API in relation to MSAA, for now, I've just done this with a comment attached

@heavyrain266
Copy link
Owner

Hmmm... what do you think about turning title section on the bottom bar into input field? so you could dynamically update window title instead of just displaying it since it's already displayed in titlebar unless you use Linux with some WM/Compositor which doesn't provide titlebars 🤔

@BlackPhlox
Copy link
Contributor Author

Hmm, text_edit_singleline takes mutable ref, not really applicable for bevy_window, might have to do something custom listening thing. Also, congrats on your job offer 🎉

@BlackPhlox
Copy link
Contributor Author

Nvm, it wasn't that hard 😅, I'll push in a sec 👍

@heavyrain266
Copy link
Owner

Thanks, I'd tried to do that but failed with input section which was displaying window name and couldn't change it.

@BlackPhlox BlackPhlox marked this pull request as ready for review January 24, 2022 13:44
@heavyrain266 heavyrain266 merged commit 3decc71 into heavyrain266:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants