Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name "May" recognized as month in german #69

Open
kno10 opened this issue Jan 19, 2018 · 1 comment
Open

Name "May" recognized as month in german #69

kno10 opened this issue Jan 19, 2018 · 1 comment

Comments

@kno10
Copy link

kno10 commented Jan 19, 2018

Example texts:

Mrs May praised the "uniquely close relationship" between the two nations.

May entgegnete, sie akzeptiere, dass ihr Land nach dem Brexit "kein vollständiges Mitglied" des EU-Binnenmarkts mehr sein werde. Aber es sei in beiderseitigem Interesse, "weiterhin gute Wirtschaftsbeziehungen zu haben".

Another famous May:

Ab 1856 studierte May als Proseminarist am Lehrerseminar in Waldenburg. Dort wurde er im Januar 1860 wegen Unterschlagung von sechs Kerzen ausgeschlossen.

We should add some rule to prevent this kind of matches; in particular since the month is written "Mai" in German. But above is also an English example.

@JannikStroetgen
Copy link
Member

You are right. We added "May" in the context of processing historic German literature - but it's probably not a good idea.
I planned to have a rule forbidding matches of ambiguous terms on their own, i.e., to allow "May 2000" but not just "May" - the same my also hold for "August" if there is no temporal signal before or any other time-related patterns with which it can be combined.

I hope to find some time in February to integrate a couple of things in a new HeidelTime release...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants