Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when sorting large table by non-indexed column #622

Open
hkaraoglu opened this issue Apr 22, 2019 · 4 comments
Open

Warn when sorting large table by non-indexed column #622

hkaraoglu opened this issue Apr 22, 2019 · 4 comments

Comments

@hkaraoglu
Copy link

hkaraoglu commented Apr 22, 2019

Steps to reproduce this issue

  1. Step 1;
    Open a table that has a binary column.
  2. Step 2;
    Click on binary column to sort data.
  3. Step 3;
    If you have big data on this column or many rows on this table, it crashes after a while.

Current behavior

When I click on binary or blob data column accidently, it tries sort data by this column. But this column has big data and no need to sort it. Because it stores binary (file, image or another). That's not meaningful to sort.

Possible solution

Disable sort for binary and blob column.

Environment

  • HeidiSQL version:
    10.1.0.5464 (64Bit)

  • Operating system:
    Windows 10

@ansgarbecker
Copy link
Collaborator

There may be tables out in the world which store smaller things than images in blobs. So I'm heavily against disabling the possibility to "sort by accident".

What Heidi may do here is to warn the user, if the column has a large data type (blob and text) AND if the table's size is over 100M or so.

@ansgarbecker ansgarbecker changed the title Disable sort for blob data Warn when sorting large table by non-indexed column Apr 22, 2019
@ansgarbecker
Copy link
Collaborator

Or, even better: As sorting by non-indexed columns is generally slow, Heidi could warn if the column is not indexed (plus the table has >100M)

@Ivan-Perez
Copy link
Contributor

Giving the ability to stop the query (and reset the sort order) if it takes too long to load the data would be a good idea aswell. Currently, the program freezes when the server takes several minutes to sort the data on huge tables.

@ansgarbecker
Copy link
Collaborator

Related: issue #1868, now fixed, resets a previous sort order on a table before opening the data tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants