Temporary fix for #109 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, let's push the temporary fix to Hackage. Thanks! |
HeinrichApfelmus
added a commit
that referenced
this pull request
Aug 4, 2015
Temporary fix for #109
HeinrichApfelmus
added a commit
that referenced
this pull request
Aug 10, 2015
The children and the event handlers associated to an ‘Element’ are now managed by two separate ‘RemotePtr’. Previously, both the children of an ‘Element’ and the event handlers associated to this element where “attached” to it by using ‘Foreign.addReachable’. Clearing all child elements had the nasty side effect of removing the event handlers as well. Now, we can use ‘Foreign.clearReachable’ on the ‘elChildren’ pointer to sever the connection to the child elements, allowing them to be garbage collected if there is no reference to them on the server side anymore. Fix #109, #113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements @HeinrichApfelmus's suggested fix to #109.
Could we get this up on Hackage?