Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FullPageSlide scrolls down on mobile when tapped #58

Open
Siutan opened this issue Aug 14, 2023 · 2 comments · May be fixed by #59
Open

FullPageSlide scrolls down on mobile when tapped #58

Siutan opened this issue Aug 14, 2023 · 2 comments · May be fixed by #59
Labels
bug Something isn't working

Comments

@Siutan
Copy link

Siutan commented Aug 14, 2023

Describe the bug
FullPageSlide scrolls down when user taps anywhere on screen. Only happens on mobile.

To Reproduce
Steps to reproduce the behavior:

  1. Add FullPageSlide section
  2. Access on mobile
  3. Tap anywhere
  4. See scroll effect

Expected behavior
Nothing should happen.

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g.Edge]
  • Version [e.g. 115.0.1901.203]

Smartphone (please complete the following information):

  • Device: [e.g. Samasung Galaxy Fold 4]
  • OS: [e.g. Android 13]
  • Browser [e.g. Chrome]
  • Version [e.g. 115.0.5790.166]
@Hejtmus Hejtmus added the bug Something isn't working label Aug 16, 2023
@Hejtmus
Copy link
Owner

Hejtmus commented Aug 16, 2023

Hey @Siutan,

thanks for report, I successfully reproduced your bug, I will try to fix it ASAP, I hope I can get to it until end of this week.
If you need it sooner and you are willing to fix it, feel free to make PR.

Best regards,
Filip.

@Siutan Siutan linked a pull request Aug 18, 2023 that will close this issue
Open
@Siutan
Copy link
Author

Siutan commented Aug 18, 2023

Hey there @Hejtmus,
I've just submitted a PR for this issue with 2 proposed solutions. Let me know your thoughts on it.

Thanks,
Mukil

@Hejtmus Hejtmus mentioned this issue Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes issue #58 Siutan/svelte-fullpage-issue-5-fix
2 participants
@Hejtmus @Siutan