Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor LaueAssigner + LauePredictor to a sensible inheritance scheme #10

Open
PrinceWalnut opened this issue Mar 31, 2022 · 1 comment
Open

Refactor LaueAssigner + LauePredictor to a sensible inheritance scheme #10

PrinceWalnut opened this issue Mar 31, 2022 · 1 comment

Comments

@PrinceWalnut
Copy link
Member

A general Laue class with Predictor + Assigner inheritance
@kmdalton
Copy link
Member

I would suggest making a base class which Predictor and Assigner both extend. They do largely the same stuff. This is a nice refinement to make after we have a prototype.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kmdalton @PrinceWalnut