Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Waveguide.add_route_straight_to_port #29

Merged
merged 2 commits into from Oct 29, 2020
Merged

Add Waveguide.add_route_straight_to_port #29

merged 2 commits into from Oct 29, 2020

Conversation

fbeutel
Copy link
Contributor

@fbeutel fbeutel commented Oct 28, 2020 •
edited

Add method add_route_straight_to_port to Waveguide. Allows routing a straight segment to a target port and tapers the width linearly on the way.

This can be used for electrode contact pads etc.

route_port

@HelgeGehring HelgeGehring added the enhancement New feature or request label Oct 28, 2020
@HelgeGehring
Copy link
Owner

Looks good!
I'd guess a test for another angle than 0 and 90° would make sense, what do you think?

@HelgeGehring
Copy link
Owner

And could you fix the formatting? Flake8 shows some warnings

@fbeutel
Copy link
Contributor Author

fbeutel commented Oct 28, 2020

ok, updated the formatting and added another test case

@HelgeGehring
Copy link
Owner

Thanks!

@HelgeGehring HelgeGehring merged commit de0a9f4 into HelgeGehring:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fbeutel @HelgeGehring