Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should these be size_t vs int64_t? #12

Open
andyburke opened this issue Sep 4, 2018 · 2 comments
Open

Should these be size_t vs int64_t? #12

andyburke opened this issue Sep 4, 2018 · 2 comments

Comments

@andyburke
Copy link
Member

int64_t Seek( int64_t offset, SeekOrigin origin );

It seems like the issues with #11 passing tests have to do with a mismatch between size_t and int64_t on some platforms.

@gorlak
Copy link
Member

gorlak commented Sep 4, 2018

They can't be size_t because size_t is unsigned and offset is directional (you can seek by negative bytes)

@gorlak
Copy link
Member

gorlak commented Sep 4, 2018

I think that @VictorStepanov should probably make the locals in his test int64_t's instead of size_t via a cast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants