Skip to content
This repository has been archived by the owner on Oct 17, 2023. It is now read-only.

Error creating embedded templates when there are no merge fields #55

Closed
codesometech opened this issue Apr 13, 2017 · 7 comments
Closed
Labels

Comments

@codesometech
Copy link

I am seeing the below exception while creating an embedded template using the Java SDK 4.0.3. I see that the request object has "[]" for merge_fields. I this it is because of that. Can you please take a look. I am including screen shots and code snippet from TemplateDraft.java for your reference. I think an empty check on mergeFileds map should fix the issue.

com.hellosign.sdk.HelloSignException: Merge field is missing "name" parameter
	at com.hellosign.sdk.http.HttpClient.validate(HttpClient.java:177)
	at com.hellosign.sdk.http.HttpClient.asJson(HttpClient.java:210)
	at com.hellosign.sdk.HelloSignClient.createEmbeddedTemplateDraft(HelloSignClient.java:939)

image

image

@mveitas
Copy link

mveitas commented Apr 14, 2017

PRs are always welcome, hence why this is open source :)

@cmpaul
Copy link
Contributor

cmpaul commented Apr 14, 2017

@codesometech Thanks for the screenshots and explanation, seems straightforward enough. I'll see if I can get a patch out in the next few days.

@cmpaul cmpaul added the bug label Apr 14, 2017
@cmpaul cmpaul self-assigned this Apr 14, 2017
cmpaul pushed a commit that referenced this issue Apr 17, 2017
@cmpaul
Copy link
Contributor

cmpaul commented Apr 17, 2017

@codesometech Can you take a look at PR #57 and let me know if that will work for you?

@cmpaul
Copy link
Contributor

cmpaul commented Apr 18, 2017

@codesometech This has been merged to develop. If you're so inclined, you can check out that branch and build (it will build version 4.0.4-SNAPSHOT) to test. I'll plan to release the official patch bump next week.

@codesometech
Copy link
Author

@cmpaul Thank you.

@codesometech
Copy link
Author

@cmpaul I tested this locally and it looks good. Could you please release this.

@cmpaul
Copy link
Contributor

cmpaul commented May 7, 2017

@codesometech This has been released as v4.0.4. Please update and let me know if you have any issues. Thanks for your help!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants