New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Necessary code changes to support Python3 #1773
Comments
@mkg20001 |
@DaniellMesquita depends on how hard it is to get python3 running on android |
https://kivy.org/doc/stable/faq.html#does-kivy-support-python-3-x |
@DaniellMesquita That's.... not what that says. Edit: It says Python 3 is now usable with Kivy (including for android because of python-for-android supporting python 3 - hence the word "also"), but the build tools for iOS require Python 2. TL;DR: You don't need python 2 to run on iOS with python 3, you just need it for the build tools. |
Please note that in python-bitcointx, the python package has just been renamed from 'bitcoin' to 'bitcointx' (Simplexum/python-bitcointx#7). Also, use_libsecp256k1_for_signing() function will be gone after ,Simplexum/python-bitcointx#14 gets merged, because signing with libsecp256k1 will be the default. |
Hello everyone! Quick questions:
|
|
Is that AES-256? |
https://github.com/HelloZeroNet/ZeroNet/blob/master/plugins/CryptMessage/CryptMessage.py#L7 |
@HelloZeroNet Ah makes sense, thanks! Could you please ping me on the PR that adds |
@ofek Sure, this is the code what we going to use: https://gist.github.com/HelloZeroNet/c82198335b430b51d86f9d6484fd91c2 I got it from a ZeroNet user (@MuxZeroNet) a few months ago. Please let me know if you have suggestions. (We only going to use it for verification as the signing is pretty rare operation) |
AES-256 is quantum resistant in medium-therm. But Bitcoin cryptography (that gives life to zites) isn't. |
@HelloZeroNet For the Please let me know when the PR arrives 🙂 |
First Python3 version is ready for testing: https://github.com/HelloZeroNet/ZeroNet/tree/py3 What's left before release:
|
There was various compatibility problems with Python 3.5 (some of them was tricky to reproduce), but I was able to fix it and it should work now. The last Windows XP compatible Python version is 3.4, so I will try to make it work as well |
Ok, so PeerMessage now supports Python 3 Version of ZeroNet - in the py3 branch. |
@HelloZeroNet Uploading big files doesn't seem to work. If you upload a file to KxoNetwork (I just uploaded a plugin), I get this error:
Sounds like the hash is None. If I upload a file to ZeroUp, I get this:
In case you need the files, here they are: |
@imachug Thanks for reporting, working on it! |
Should be fixed in Rev4048 87abdb9 |
It's actually half-fixed, I get this error:
However, the file is uploaded correctly. |
@imachug try with PR #1982 |
@HelloZeroNet I'm getting this error when I startup ZeroNet. I have the Bootstrap plugin enabled. I'm not sure if you've finished making this plugin work with py3 (I didn't see it in TODO list, I don't think):
|
I think I've seen an issue about Bootstrapper but I can't find it now. |
@HelloZeroNet Shouldn't this be closed as ZeroNet now supports Python 3? Also, can you push some changes to |
@HelloZeroNet Can we close this now? |
General
_("...")
style (to also get automatic escaping)Source code changes
main.py:
Content/ContentManager.py:
Crypt/CryptBitcoin.py:
Crypt/CryptConnection.py:
File/*
Peer/PeerServer.py
Ui/UiRequest.py
Ui/UiWebsocket.py
Dependencies
Binary dependencies
Dev dependencies
Deployment
Crypto benchmarks
Platform: Win10, Python 3.7.1 64bit
Signing x1000:
Verification x1000:
Test
TODO:
The text was updated successfully, but these errors were encountered: