Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket connection with HTTP_HOST "127.0.0.1" denied access #1799

Closed
anoadragon453 opened this issue Dec 4, 2018 · 2 comments
Closed

Websocket connection with HTTP_HOST "127.0.0.1" denied access #1799

anoadragon453 opened this issue Dec 4, 2018 · 2 comments

Comments

@anoadragon453
Copy link
Contributor

Trying to make a websocket connection from Godot to ZeroNet fails by default as the HTTP_HOST env property of the connection is 127.0.0.1 instead of 127.0.0.1:43110. This is likely an issue on Godot's websocket library side, but would adding 127.0.0.1 and localhost to the list of default allowed hosts be a problem in any way?

As a reminder, the current default values are zero, 127.0.0.1:zeronet_port and localhost:zeronet_port.

@HelloZeroNet
Copy link
Owner

Actually I think we could white-list any ip address as dns rebinding attacks is only affects domain names

@anoadragon453
Copy link
Contributor Author

Oh, ok, I shall make a PR for that then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants