Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EllipticCurvePoint.SignECDSA k is not cryptographically secure #3

Closed
Javantea opened this issue Jan 13, 2015 · 1 comment
Closed

EllipticCurvePoint.SignECDSA k is not cryptographically secure #3

Javantea opened this issue Jan 13, 2015 · 1 comment

Comments

@Javantea
Copy link

I found a vulnerability in EllipticCurvePoint.SignECDSA. You use random.randint to generate k. random.randint is not a cryptographically secure random number generator.

From Wikipedia:
3. Select a cryptographically secure random integer k from [1, n-1].

Using a weak PRNG for k can result in the compromise of the private key d. For example: "Such failure of RNG caused users of Android Bitcoin Wallet to lose their funds in August 2013."
https://en.wikipedia.org/wiki/Elliptic_Curve_Digital_Signature_Algorithm

@HelloZeroNet
Copy link
Owner

Thanks for reporting, its fixed: 6424c82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants