Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Translation support #82

Closed
wants to merge 4 commits into from

Conversation

luismanson
Copy link
Contributor

@luismanson luismanson commented Sep 6, 2022

Hi, this is a basic i18next implementation, language has been set to English as default/fallback.
Also added react Suspense and Mantine LoadingOverlay.

PS: I think the copy/copied tootltip is not working

src/index.js Outdated Show resolved Hide resolved
@bjarneo
Copy link
Member

bjarneo commented Sep 6, 2022

Looks good to me. Just one comment about the import. That is it. Great work!

@bjarneo
Copy link
Member

bjarneo commented Sep 6, 2022

PS: I think the copy/copied tootltip is not working

hm, yes, seems to be something fishy on mobile here. Works in Chrome for me on desktop at least

@bjarneo bjarneo changed the title Translation support feat: Translation support Sep 6, 2022
@bjarneo bjarneo mentioned this pull request Sep 6, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bjarneo
Copy link
Member

bjarneo commented Sep 6, 2022

Seems that these are missing from the package.json:

import i18next from 'i18next';
import { initReactI18next } from 'react-i18next';
import HttpApi from 'i18next-http-backend';

@luismanson
Copy link
Contributor Author

I forgot to take care of package.json, I did not merge it, since after pulling the code npm refused to run "client-dev".
Had to install "@emotion/cache, @emotion/react and webpack" until it worked 😕

How would you handle this? I could just revert my file and add only the missing packages related to this PR, not sure if doing this would introduce new issues.

@bjarneo
Copy link
Member

bjarneo commented Sep 6, 2022

I can have a look at this for you. For my part I did not have to do what you needed to. Just pull the code, run npm install, and then it should work. But let me test the PR locally.

@bjarneo bjarneo mentioned this pull request Sep 6, 2022
@bjarneo
Copy link
Member

bjarneo commented Sep 6, 2022

#83

@bjarneo bjarneo closed this Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants