-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked Holy Dagger Textures #6
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Full Functionality to Void Heart (refilling Food) Added TickHandler Made Items their own Classes Added NbtData Saving
You can level your Immortality for bonus Powers and to achieve a Void Heart You gain an extra Heart for every Death You cannot die When falling out of world you go to your bed, otherwise your dimension spawn, otherwise overworld spawn You won't gain an extra Heart for Void Damage (out of world or /kill) Fixed Item Overlay Popup when consuming heart
…VoidHeart is applied, also overworked all prior used of Effects
The Liver gives Immortality, but when dying you lose a heart instead of, leveling When LiverImmortality reaches 0 Hearts, the killing Player will be said to have resulted in them losing their immortality If the Immortal died themselves it will simply say, that they've lost their Immortality, instead of prior usage being giving immortality up Added Holy Dagger Holy Dagger can be used by Real Immortals (having used Heart of Immortality) When used it will remove their Liver of Immortality and break, thus temporarily weakining them After 5 Minutes the weakening will end, and they'll have regrown their Liver of Immortality Fixed prior implementation of giving or taking extra Hearts now will no Longer result in ServerSide Exceptions, whilst still resulting in their expected behavior
Added TODO list in [readme.md]
Added Achievments for every significant Step (not for Leveling) Added Item Descriptions Added Crafting Recipes for Void Heart & Holy Dagger Added New Secret Effect Fixed Immortal Hearts staying behind Fixed Immortals burning or without Air if dying whilst burning/drowning Fixed Sounds only being on Immortal Player Client, now played for others aswell
Removed API as it only works ServerSide, thus disabling the mod from being used in SinglePlayer Added Events standalone, without API, whilst allowing usage of them even in SinglePlayer Failed to do ServerWorld Nbt Saver, added it to TODO
Added Cardinal Components API as it "easily" solves the problem of attaching data to the world without it being discarded upon saving This API will likely stay, as a manual implementation would not be worth it, especially as it's unlikely to port the Mod to versions not supported by the API
When consuming Heart of Immortality / Void Heart or Liver of Immortality you no longer lose their effects Consuming Liver of Immortality after losing Hearts, you regain your Original Hearts You can use Holy Dagger 3 times in a second to lose all your Hearts, not to remove your Liver of Immortality You will constantly be extinguished from now on, if Immortal, or False Immortal Added Players having True Immortality radiating their Immortality, causing their Armor and held Items being slowly repaired Fixed Bug of Player killing themselves on their last False Immortality Heart causing the Server to crash
Update to latest Commit
Fixed Bug where Player could kill themselves on Last Life again, and thus lose False Immortality without dying
… registering them as Attackers, because of flick kills
Fixed error Message in console from advancement liver_of_immortality
Looks like worse than before, create a new one, when it looks atleast as good |
Hempflingclub
requested changes
Oct 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worse than before, please rework again
okay i try best to look it better |
Changed implementation to use Components now for PlayerData Removed PlayerDataSaverMixin.java Refactored to accompany new Component implementation Refactored overusage of ImmortalityData.java into ImmortalityStatus.java Implementated Syncing of Playerdata Fixed Bug of Item Rendering happening when not originally intended
Fixed Bug of Liver of Immortality not working as intended in worlds younger than 5 Minutes
Fixed Bug of Not being able to get Achievment for extracting Liver when already True Immortal Fixed Bug of Command not displaying that you need to extract your liver when you already have 30 Deaths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5